-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-Conservative Zonal Mean #1004
base: main
Are you sure you want to change the base?
Conversation
@erogluorhan @hongyuchen1030 @paullric For zonal averaging, would the primary difference between Conservative and Non-Conservative be whether we apply a weighted average as opposed to performing a standard average? |
As I explained before here #785 (comment) Both use weighted average But non-conservative one use the arc length, conservative use the area as weights |
Sorry for the duplicate! Send this one without seeing your comment before. Appreciate the clarification |
For reference, the pre-commit is failing in all the PR's and CI's too. |
There is currently a large bottleneck in perfromance due to the weight computation. See below a profile of the 30km MPAS grid, with latitudes between -45 and 45 degrees using a 2 degree spacing. Despite this, @rajeeja @aaronzedwick @amberchen122 , you may begin to review this PR. @hongyuchen1030 and I will continue to investigate performance optimizations. If we do not finish them by the time reviews are done, we can continue to iterate after it is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Pinning @amberchen122 for a closer look of the implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thank you for transferring the changes over. Well done!
Closes #93
Overview