User Guide on Custom Grids & .from_xarray() methods
#1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have another PR for from_file and loading grids; do you think we want to merge that with this one? |
I think it's okay to keep them separate, as the one you are working on covers different areas than this one. |
…rray into philipc2/custom-grid
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
philipc2
changed the title
.from_xarray() methods.from_xarray() methods
|
May you take a look at this PR when you both have some time? |
rajeeja
reviewed
Jan 17, 2025
| @@ -220,7 +220,7 @@ def from_dict(cls, data, **kwargs): | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def from_structured(cls, ds: xr.Dataset, tol: Optional[float] = 1e-10): | |||
| def from_structured(cls, ds: xr.Dataset): | |||
There was a problem hiding this comment.
This is not related to this PR, why is the tolerance removed?
There was a problem hiding this comment.
Noticed this when I was working on the code; this variable wasn't used / was leftover.
rajeeja
approved these changes
Jan 17, 2025
rajeeja
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
UxDataArray.from_xarray()andUxDataset.from_xarray(), methods for converting from Xarray to UXarray with a customGrid