Create advertisement #119
Merged
Create advertisement #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4288276.
rogargon
reviewed
Dec 15, 2024
| private void initializeAdStatus() { | ||
| if (this.adStatus == null) { | ||
| this.adStatus = AdvertisementStatusRepositoryHolder.getRepository() | ||
| .findById(1L) |
There was a problem hiding this comment.
It is risky to depend on a specific ID; it is better to use find by status name, which also makes the code easier to understand. Moreover, if this is critical, you can also create the required status if it has not been done yet.
Finally, if done with a PrePersist and the Handler is not required (note it is Handler, not Holder), the Handler can be removed
rogargon
requested changes
Dec 15, 2024
|
Solved |
rogargon
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.