Skip to content

Commit

Permalink
Batch Student Solver Reports: Export CSV
Browse files Browse the repository at this point in the history
- corrected permission checking for the published student scheduling solver
  - either StudentSectioningSolverReports or StudentSectioningSolver is needed
- this fixes an issue for Student Scheduling Manager role
  • Loading branch information
tomas-muller committed Feb 28, 2024
1 parent d980b78 commit 07b2e9c
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ public void export(ExportHelper helper) throws IOException {
SessionContext context = helper.getSessionContext();
DataProperties config = null;
if (online == null) {
context.checkPermissionAnyAuthority(sessionId, "Session", Right.StudentScheduling);
if (!context.hasPermission(Right.StudentSectioningSolverReports))
context.checkPermission(Right.StudentSectioningSolver);

StudentSolverProxy solver = studentSectioningSolverService.getSolver("PUBLISHED_" + sessionId, sessionId);
if (solver == null)
Expand Down Expand Up @@ -125,7 +126,8 @@ public void export(ExportHelper helper) throws IOException {

csv = solver.getReport(parameters);
} else {
context.checkPermissionAnyAuthority(sessionId, "Session", Right.StudentSectioningSolver);
if (!context.hasPermissionAnyAuthority(sessionId, "Session", Right.StudentSectioningSolverReports))
context.checkPermissionAnyAuthority(sessionId, "Session", Right.StudentSectioningSolver);

StudentSolverProxy solver = studentSectioningSolverService.getSolver();
if (solver == null)
Expand Down
13 changes: 13 additions & 0 deletions WebContent/help/Release-Notes.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,19 @@
<release>
<version>4.7.${build.number}</version>
<release-date>${build.date}</release-date>
<category>
<title>Student Scheduling</title>
<item>
<name>Batch Student Solver Reports: Export CSV</name>
<description>
<line>Corrected permission checking for the published student scheduling solver.</line>
</description>
</item>
</category>
</release>
<release>
<version>4.7.109</version>
<release-date>Fri, 26 Jan 2024</release-date>
<category>
<title>Course Timetabling</title>
<item>
Expand Down

0 comments on commit 07b2e9c

Please sign in to comment.