Skip to content

Commit

Permalink
feat(v3-sdk): bump sdk-core to have worldchain chain id (#130)
Browse files Browse the repository at this point in the history
## Description

Bump sdk-core in v3-sdk. v3-sdk uses ChainId enum from sdk-core https://github.com/search?q=repo%3AUniswap%2Fsdks+sdk-core+path%3A%2F%5Esdks%5C%2Fv3-sdk%5C%2F%2F&type=code, so v3-sdk needs worldchain chain id

## How Has This Been Tested?

Will test in routing.

## Are there any breaking changes?

No

## (Optional) Feedback Focus

## (Optional) Follow Ups
  • Loading branch information
jsy1218 authored Oct 1, 2024
1 parent 53e3cc3 commit 2a68888
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sdks/v3-sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@ethersproject/abi": "^5.5.0",
"@ethersproject/solidity": "^5.0.9",
"@uniswap/sdk-core": "^5.3.1",
"@uniswap/sdk-core": "^5.6.0",
"@uniswap/swap-router-contracts": "^1.3.0",
"@uniswap/v3-periphery": "^1.1.1",
"@uniswap/v3-staker": "1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4867,7 +4867,7 @@ __metadata:
"@ethersproject/abi": ^5.5.0
"@ethersproject/solidity": ^5.0.9
"@types/jest": ^24.0.25
"@uniswap/sdk-core": ^5.3.1
"@uniswap/sdk-core": ^5.6.0
"@uniswap/swap-router-contracts": ^1.3.0
"@uniswap/v3-core": 1.0.0
"@uniswap/v3-periphery": ^1.1.1
Expand Down

0 comments on commit 2a68888

Please sign in to comment.