fix: avoid import conflicts between v4-sdk and ethers-v6 #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v4-sdk
uses ethers v5, which is slowly going away. Many project that importv4-sdk
may also have ethers-v6 in their dependency. This creates conflicts, becausev4-sdk
importsethers
directly (instead of importing@ethersproject/xxx
).How Has This Been Tested?
This is only a change to the imports. There should be no feature changes. Was tested with
yarn test
Are there any breaking changes?
There shouldn't be any.
Feedback Focus
The dependencies of the
v4-sdk
package do not includeethers
. It only contains@ethersproject/solidity
. However,v4-sdk
does use features from all of the followingMaybe they should be added to the dependencies in a more explicit way
Follow Ups
Migration to ethers v6: #141