-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-core): add monad testnet #212
Conversation
sdks/sdk-core/src/addresses.ts
Outdated
|
||
export const CHAIN_TO_ADDRESSES_MAP: Record<SupportedChainsType, ChainAddresses> = { | ||
// exclude monad because it doesn't have v3 support | ||
export const CHAIN_TO_ADDRESSES_MAP: Omit<Record<SupportedChainsType, ChainAddresses>, ChainId.MONAD_TESTNET> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to Omit<Record<SupportedChainsType, ChainAddresses>, ChainId.MONAD_TESTNET>
doesn't seem like a great solution. So far we have relied on SupportedChainsType enum strong type to ensure we don't miss an address on any supported chain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this to unblock urgent wallet PR but we'll need to revisit (maybe launch v3 anyways?) for web
sdks/sdk-core/src/addresses.ts
Outdated
@@ -303,8 +303,8 @@ const UNICHAIN_ADDRESSES: ChainAddresses = { | |||
tickLensAddress: '0xd5d76fa166ab8d8ad4c9f61aaa81457b66cbe443', | |||
swapRouter02Address: '0x73855d06de49d0fe4a9c42636ba96c62da12ff9c', | |||
} | |||
|
|||
export const CHAIN_TO_ADDRESSES_MAP: Record<SupportedChainsType, ChainAddresses> = { | |||
// exclude monad because it doesn't have v3 support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be a blocker for routing. do we need why no v3 support? is it because of no v3 protocol deploy on monad testnet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they only want v2 for their competition: https://www.notion.so/uniswaplabs/Monad-Testnet-12fc52b2548b802b8012ff65a9b376ba?pvs=4#12fc52b2548b8071a11ae1c56ae73dcd
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/05/24)1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
PR Scope
Please title your PR according to the following types and scopes following conventional commits:
fix(SDK name):
will trigger a patch versionchore(<type>):
will not trigger any release and should be used for internal repo changes<type>(public):
will trigger a patch version for non-code changes (e.g. README changes)feat(SDK name):
will trigger a minor versionfeat(breaking):
will trigger a major version for a breaking changeDescription
Adds Monad Testnet.
Unblocks review on https://github.com/Uniswap/universe/pull/14305
How Has This Been Tested?
Linked to local repo and ensure everything runs as expected
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
No
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...
), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.(Optional) Feedback Focus
[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]