Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(universal-router-sdk): update universal router plus nits #231

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

dianakocsis
Copy link
Contributor

… router

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

@dianakocsis dianakocsis requested review from jsy1218 and a team as code owners January 7, 2025 23:09
Copy link

graphite-app bot commented Jan 7, 2025

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (01/07/25)

1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@dianakocsis dianakocsis changed the title feat(universal-router-sdk): update universal router plus nits chore(universal-router-sdk): update universal router plus nits Jan 8, 2025
@jsy1218
Copy link
Member

jsy1218 commented Jan 21, 2025

so my router-sdk PR is seeing UR-related forge test failures again https://github.com/Uniswap/sdks/actions/runs/12897148582/job/35961634522?pr=253, which makes me think that forge update has to be in first.

@jsy1218 jsy1218 merged commit e07d496 into main Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants