Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-core): update chain ID for Monad Testnet #238

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

BZahory
Copy link
Collaborator

@BZahory BZahory commented Jan 10, 2025

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

Updates chain ID for Monad Testnet

[Summary of the change, motivation, and context]

How Has This Been Tested?

Linked to universe repo to verify the package resolves correctly, but e2e testing is blocked pending other changes.

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

Unsure (will verify)

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

Not sure if this is considered breaking

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

@BZahory BZahory requested review from jsy1218 and a team as code owners January 10, 2025 08:39
@BZahory BZahory changed the title chore(sdk-core): update chain Id chore(sdk-core): update chain ID for Monad Testnet Jan 10, 2025
Copy link

graphite-app bot commented Jan 10, 2025

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (01/10/25)

1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@jsy1218
Copy link
Member

jsy1218 commented Jan 10, 2025

PR title cannot be chore

chore(): will not trigger any release and should be used for internal repo changes

fix seems correct

fix(SDK name): will trigger a patch version

@BZahory BZahory changed the title chore(sdk-core): update chain ID for Monad Testnet fix(sdk-core): update chain ID for Monad Testnet Jan 10, 2025
@BZahory BZahory merged commit 2fb8235 into main Jan 10, 2025
11 checks passed
@BZahory BZahory deleted the monad-testnet-chain-id-update branch January 10, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants