Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup for style and base components #18

Merged
merged 8 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions .eslintrc.js

This file was deleted.

19 changes: 19 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"parser": "@typescript-eslint/parser",
"extends": [
"plugin:security/recommended-legacy",
"plugin:@typescript-eslint/recommended"
],
"plugins": ["jsx-a11y", "tailwindcss"],
"rules": {
"tailwindcss/no-custom-classname": "off",
"tailwindcss/classnames-order": "off",
"@typescript-eslint/no-unused-vars": 1,
"@typescript-eslint/ban-ts-ignore": 0,
"@typescript-eslint/ban-ts-comment": 0,
"@typescript-eslint/no-explicit-any": 0,
"no-unused-vars": 0,
"security/detect-object-injection": "off",
"jsx-a11y/alt-text": "off"
}
}
33 changes: 21 additions & 12 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,27 @@
## Description
### Description

<!-- a summary of the changes introduced by this PR and the motivation behind them -->
<!--- Summarize the changes that can be found in this PR and how your reviewers should test these changes. -->

## Screenshots
### Type(s) of changes

<!-- (optional) when applicable, please include some screenshots or gifs that illustrate the changes -->
<!--- Put an `x` in all the boxes that apply. -->

## Checklist
- [ ] Bug fix
- [ ] New feature
- [ ] Update to an existing feature

- [ ] :green_book: all commit messages follow the [conventional commits](https://conventionalcommits.org/) standard
- [ ] :arrow_left: changes are compatible with RTL direction
- [ ] :wheelchair: Changes to the UI are [tested for accessibility](./../README.md#accessibility-testing) and compliant with [WCAG 2.1](https://www.w3.org/TR/WCAG21/).
- [ ] :memo: changes are tested in Chrome, Firefox, Safari and Edge
- [ ] :iphone: changes are responsive and tested in mobile
- [ ] :+1: PR is approved by @zendesk/vikings
### Motivation for PR

<!-- More info about the contribution process can be found at https://github.com/zendesk/copenhagen_theme#contributing -->
<!--- If it addresses an open issue, please link to the issue here, otherwise, briefly describe the issue. -->

### How Has This Been Tested?

<!--- Please note how you have tested your changes. Browsers, accessibility, devices, unit tests, etc. -->

### Applicable screenshots

<!--- When appropriate, upload screenshots. -->

### Follow-up PR

<!--- When appropriate, please note what your reviewers can expect in a follow up PR. -->
38 changes: 2 additions & 36 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,6 @@ on:
- master

jobs:
commitlint:
name: Lint commit messages
if: ${{ github.event_name == 'pull_request' }}
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: zendesk/checkout@v3
with:
persist-credentials: false
fetch-depth: 0
- name: Setup Node.js
uses: zendesk/setup-node@v3
with:
node-version-file: '.nvmrc'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Lint all commit messages
run: yarn commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }}
lint:
name: Lint JS files
runs-on: ubuntu-latest
Expand All @@ -38,27 +20,11 @@ jobs:
- name: Setup Node.js
uses: zendesk/setup-node@v3
with:
node-version-file: '.nvmrc'
node-version-file: ".nvmrc"
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: ESlint
run: yarn eslint
test:
name: Test
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: zendesk/checkout@v3
with:
persist-credentials: false
- name: Setup Node.js
uses: zendesk/setup-node@v3
with:
node-version-file: '.nvmrc'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Test
run: yarn test
build:
name: Build
runs-on: ubuntu-latest
Expand All @@ -70,7 +36,7 @@ jobs:
- name: Setup Node.js
uses: zendesk/setup-node@v3
with:
node-version-file: '.nvmrc'
node-version-file: ".nvmrc"
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Build
Expand Down
64 changes: 33 additions & 31 deletions .github/workflows/lighthouse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,38 +10,40 @@ jobs:
- name: Setup Node.js
uses: zendesk/setup-node@v3
with:
node-version-file: '.nvmrc'
node-version-file: ".nvmrc"
- name: Install node_modules
run: yarn install --frozen-lockfile
- name: Build
run: yarn build
- name: Upload theme
run: node ./bin/theme-upload.js
env:
ZENDESK_EMAIL: ${{ secrets.zendesk_email }}
ZENDESK_API_TOKEN: ${{ secrets.zendesk_token }}
ZENDESK_SUBDOMAIN: ${{ secrets.subdomain }}
BRAND_ID: ${{ secrets.brand_id }}
- name: Audit URLs using Lighthouse
run: yarn test-a11y
env:
end_user_email: ${{ secrets.end_user_email }}
end_user_password: ${{ secrets.end_user_password }}
subdomain: ${{ secrets.subdomain }}
urls: |
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/categories/360002267479
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/sections/360003307259
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/articles/360010829359
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/requests/new
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/search?utf8=%E2%9C%93&query=Help+Center
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/topics
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/topics/360000644279
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/posts
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/posts/360006766799
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/profiles/364655812519
https://${{ secrets.subdomain }}.zendesk.com/hc/contributions/posts?locale=en-us
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/subscriptions
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/requests
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/requests/3
https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/posts/new
# deactivate this step since it will make the current theme live on production
# TODO: activate this with configuration once the theme is ready for production
# - name: Upload theme
# run: node ./bin/theme-upload.js
# env:
# ZENDESK_EMAIL: ${{ secrets.zendesk_email }}
# ZENDESK_API_TOKEN: ${{ secrets.zendesk_token }}
# ZENDESK_SUBDOMAIN: ${{ secrets.subdomain }}
# BRAND_ID: ${{ secrets.brand_id }}
# - name: Audit URLs using Lighthouse
# run: yarn test-a11y
# env:
# end_user_email: ${{ secrets.end_user_email }}
# end_user_password: ${{ secrets.end_user_password }}
# subdomain: ${{ secrets.subdomain }}
# urls: |
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/categories/360002267479
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/sections/360003307259
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/articles/360010829359
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/requests/new
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/search?utf8=%E2%9C%93&query=Help+Center
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/topics
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/topics/360000644279
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/posts
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/posts/360006766799
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/profiles/364655812519
# https://${{ secrets.subdomain }}.zendesk.com/hc/contributions/posts?locale=en-us
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/subscriptions
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/requests
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/requests/3
# https://${{ secrets.subdomain }}.zendesk.com/hc/en-us/community/posts/new
30 changes: 0 additions & 30 deletions .github/workflows/release.yml

This file was deleted.

4 changes: 0 additions & 4 deletions .husky/commit-msg

This file was deleted.

2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.12.1
v18.18.0
5 changes: 5 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.vscode
.yarn
dist
templates
translations
18 changes: 0 additions & 18 deletions .releaserc

This file was deleted.

Loading
Loading