-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add side nav and 404 page #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h3 | ||
className={cn('subheading-2 my-3', { | ||
'text-light-accent-1 dark:text-dark-accent-1': categoryisActive, | ||
'text-light-neutral-2 dark:text-dark-neutral-2': !categoryisActive, | ||
})} | ||
> | ||
{category.name} | ||
</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these category headings should also be clickable:
https://www.loom.com/share/96544e49e4064d78a86898d77d7b18e6?sid=2fe406d9-4a1d-40f6-9cdb-ac5657f6d2af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it! on nav, I think we should go though hover state with designer. I felt like it is not consistant but I guess we can handle that on QA!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add side nav items to the mobile nav modal(design). Let's handle it in the separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just a couple small things. No additional comments besides Nahee's
{ | ||
hidden: i === 0, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can prob just do first:hidden
here so you don't need to use js logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not actually first element inside of the div 🥲 it has button div above it so I just added that
<a href={category.url}> | ||
<h3 | ||
className={cn( | ||
'transitoin subheading-2 my-3 hover:text-light-accent-1 hover:dark:text-dark-accent-1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: transition
Description
Type(s) of changes
Motivation for PR
#26 #16
Applicable screenshots
https://www.loom.com/share/621e215a90fb4e9a9bce5bd50f060350?sid=958c8a51-a045-4cff-a1a5-d890e3f37f6c