Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side nav heading fix #38

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Side nav heading fix #38

merged 2 commits into from
Dec 9, 2024

Conversation

nahbee10
Copy link
Collaborator

@nahbee10 nahbee10 commented Dec 9, 2024

Description

  • shortened side nav API update cadence so that the client can preview the changes while QAing is happening
  • added one condition to decide items for side nav(on this page)
    • if the heading has any elements with side-nav-item, the text inside it will be used for the side nav items. If not, just use h1-h4 heading tags for the side nav

Type(s) of changes

  • Bug fix
  • New feature
  • Update to an existing feature

Motivation for PR

  • client's request via slack

How Has This Been Tested?

Tested on local and production preview

Applicable screenshots

Follow-up PR

@nahbee10 nahbee10 merged commit 485d8ba into master Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant