Add FullMath.mulDivQ128 and optimize Position.update
#601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new function named `mulDivQ128` has been added to `FullMath`. This function calculates x * y / 2^128 with full precision. The calls to `mulDiv` in `Position.sol` were updated to use this new function. The changes also resulted in a decrease in gas in multiple snapshots. Tests were added to validate the functionality of `mulDivQ128`.
This commit optimizes the overflow check within the `mulDivRoundingUp` function of FullMath library. This is achieved by combining two steps: the increment of the `result` and the overflow check, into a single step using the `++` operator. This simplifies the code, improves its readability and brings down the gas usage slightly, as reflected in updated snapshot files.
shuhuiluo
changed the title
FullMath.mulDivQ128 and optimize mulDivRoundingUpFullMath.mulDivQ128 and optimize Position.update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes
A new function named
mulDivQ128has been added toFullMath. This function calculates x * y / 2^128 with full precision. The calls tomulDivinPosition.solwere updated to use this new function. The changes also resulted in a decrease in gas in multiple snapshots. Tests were added to validate the functionality ofmulDivQ128.Also optimized the overflow check within the
mulDivRoundingUpfunction of FullMath library. This is achieved by combining two steps: the increment of theresultand the overflow check, into a single step using the++operator.