Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise before swap return fee #650

Merged
merged 2 commits into from
May 14, 2024
Merged

Optimise before swap return fee #650

merged 2 commits into from
May 14, 2024

Conversation

hensha256
Copy link
Contributor

Potential optimisation to #648

@hensha256 hensha256 changed the base branch from main to before-return-swap-fee May 14, 2024 20:36
hensha256
hensha256 commented May 14, 2024
View reviewed changes
.forge-snapshots/swap skips hook call if hook is caller.snap
225012
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key gas to look at

hensha256
hensha256 commented May 14, 2024
View reviewed changes
.forge-snapshots/swap with lp fee and protocol fee.snap
181943
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key gas to look at

hensha256
hensha256 commented May 14, 2024
View reviewed changes
.forge-snapshots/update dynamic fee in before swap.snap
160180
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key gas to look at

hensha256
hensha256 commented May 14, 2024
View reviewed changes
.forge-snapshots/swap with return dynamic fee.snap
157355
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key gas to look at

Copy link
Collaborator

@saucepoint saucepoint May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3,257!!! 😮‍💨

but i dont know if we should use the new gas (since its lower)

hensha256
hensha256 commented May 14, 2024
View reviewed changes
.forge-snapshots/swap CA custom curve + swap noop.snap
135805
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key gas to look at

saucepoint
saucepoint approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@saucepoint saucepoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it -- was one my main issues with the original impl. felt like the one-off handler callHookWithReturnDeltaAndFee wasnt very clean

@hensha256 hensha256 merged commit f424c1b into before-return-swap-fee May 14, 2024
4 checks passed
@hensha256 hensha256 deleted the optimise-before-swap-return-fee branch May 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saucepoint saucepoint saucepoint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hensha256 @saucepoint