Refactor nested ternary assignment in TickMath.getTickAtSqrtPrice
#670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formula to calculate the 'tick' value in the TickMath library has been refactored for potentially better clarity. Instead of using the conditional operator for this calculation, it has been replaced with an equivalent 'if-else' structure which may provide clearer semantic understanding.
shuhuiluo
force-pushed
the
get-tick-at-sqrt-price-1
branch
from
3cb1bb2 to
e2e0342
Compare
|
Hi! Closing this as we are not going to be merging this change 🙏 we appreciate the time you took making this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out of #273.
Related Issue
Which issue does this pull request resolve?
Description of changes
The formula to calculate the 'tick' value in the TickMath library has been refactored for potentially better clarity. Instead of using the conditional operator for this calculation, it has been replaced with an equivalent 'if-else' structure which may provide clearer semantic understanding.