position descriptor proxy tests #427
Open
+92
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Jan 10, 2025
test/PositionDescriptor.t.sol
Outdated
| @@ -48,46 +48,46 @@ contract PositionDescriptorTest is Test, PosmTestSetup { | |||
| } | |||
|
|
|||
| function test_bytecodeSize_positionDescriptor() public { | |||
| vm.snapshotValue("positionDescriptor bytecode size", address(positionDescriptor).code.length); | |||
| vm.snapshotValue("positionDescriptor bytecode size", address(proxyAsImplementation).code.length); | |||
There was a problem hiding this comment.
I would leave this as a snapshot on the actual position descriptor bytecode & then I'd just add one for the proxy too
There was a problem hiding this comment.
oh yes meant to do that
hensha256
reviewed
Jan 10, 2025
| } | ||
|
|
||
| /// @notice Returns the native currency label as a string | ||
| function nativeCurrencyLabel() public view returns (string memory) { |
There was a problem hiding this comment.
would love to see unit tests for this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
testing position descriptor as proxy
Description of changes