Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade packages to recommended versions #895

Merged
merged 14 commits into from
Jan 15, 2025

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Jan 7, 2025

Description

This PR upgrades packages in our manifest to recommended versions.
Of note, Cinemachine was upgraded to v3.1.2. This came with the deprecation of CinemachineFreeLook component, to the recommended CinemachineCamera component, forcing some scenes to also be updated.
Included upgrades:

  • com.unity.cinemachine from v2.10.3 to v3.1.2
  • com.unity.multiplayer.playmode from v1.3.2 to v1.3.3
  • com.unity.multiplayer.tools from v2.2.1 to v2.2.3
  • com.unity.netcode.gameobjects from v2.0.0 to v2.1.1

Issue Number(s)

N/A

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [ N/A ] JIRA ticket ID is in the PR title or at least one commit message
  • [ N/A ] Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review January 7, 2025 20:18
@fernando-cortez fernando-cortez requested a review from a team as a code owner January 7, 2025 20:18
@fernando-cortez fernando-cortez requested a review from a team as a code owner January 13, 2025 16:34
Copy link

@FabianStoll FabianStoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, just one issue regarding camera zoom.

Base automatically changed from feat/6000.0.32f1-lts-upgrade to develop January 14, 2025 16:32
@fernando-cortez fernando-cortez merged commit 93db2a7 into develop Jan 15, 2025
13 checks passed
@fernando-cortez fernando-cortez deleted the feat/upgrade-packages-to-recommendation branch January 15, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants