Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new input system upgrade [MTT-8681] #897

Merged
merged 30 commits into from
Jan 17, 2025

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Jan 13, 2025

Description

This PR upgrades the project to use the New Input System. Compatibility mode with the previous version has been disabled.
A PlayerActions map has been created, and all previous actions have been remapped to this asset.
As a bonus, the tooltip feature is restored in the character select screen.

Issue Number(s)

MTT-8681
MTT-3578

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review January 13, 2025 16:06
@fernando-cortez fernando-cortez requested a review from a team as a code owner January 13, 2025 16:06
@fernando-cortez fernando-cortez requested a review from a team as a code owner January 13, 2025 16:36
Copy link

@FabianStoll FabianStoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows with keyboard and mouse.
All input actions seem to work as expected except mouse wheel rotation which is not zooming in or out.

@fernando-cortez
Copy link
Collaborator Author

Tested on windows with keyboard and mouse. All input actions seem to work as expected except mouse wheel rotation which is not zooming in or out.

Should be addressed now, on desktop and mobile!

FabianStoll
FabianStoll previously approved these changes Jan 15, 2025
Copy link

@FabianStoll FabianStoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on Windows, thanks!

I tried to build and test on Android but get a build error.
Not sure if related to new input system and if it is worth investigating:

Type '[Unity.RenderPipelines.Core.Runtime]UnityEngine.Rendering.DebugActionDesc' has an extra field 'buttonAction' of type 'UnityEngine.InputSystem.InputAction' in the player and thus can't be serialized (expected 'repeatMode' of type 'UnityEngine.Rendering.DebugActionRepeatMode') UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&)

Base automatically changed from fix/removing-warnings to develop January 16, 2025 16:19
@fernando-cortez fernando-cortez dismissed FabianStoll’s stale review January 16, 2025 16:19

The base branch was changed.

@fernando-cortez fernando-cortez merged commit f33f2b2 into develop Jan 17, 2025
13 checks passed
@fernando-cortez fernando-cortez deleted the feat/new-input-system-upgrade branch January 17, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants