-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new input system upgrade [MTT-8681] #897
Conversation
…a updated to cinemachinecamera
…ompatibility mode disabled
…s-to-recommendation
…s-to-recommendation
…s-to-recommendation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on windows with keyboard and mouse.
All input actions seem to work as expected except mouse wheel rotation which is not zooming in or out.
Should be addressed now, on desktop and mobile! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on Windows, thanks!
I tried to build and test on Android but get a build error.
Not sure if related to new input system and if it is worth investigating:
Type '[Unity.RenderPipelines.Core.Runtime]UnityEngine.Rendering.DebugActionDesc' has an extra field 'buttonAction' of type 'UnityEngine.InputSystem.InputAction' in the player and thus can't be serialized (expected 'repeatMode' of type 'UnityEngine.Rendering.DebugActionRepeatMode') UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&)
The base branch was changed.
Description
This PR upgrades the project to use the New Input System. Compatibility mode with the previous version has been disabled.
A PlayerActions map has been created, and all previous actions have been remapped to this asset.
As a bonus, the tooltip feature is restored in the character select screen.
Issue Number(s)
MTT-8681
MTT-3578
Contribution checklist