Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve primary interface #26

Closed
wants to merge 18 commits into from
Closed

Improve primary interface #26

wants to merge 18 commits into from

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Sep 15, 2020

This branch will

  • Add a full primary client object structure to the client
  • Read more data from the primary interface
  • Show users when they send malformed script code to the robot
  • Inform users when they are trying to send script code to an e-Series robot which is not in remote control mode
  • Output any error messages coming up on the robot

I am not sure yet, to which extent all of those things will be tackled in this MR, but it will definitely be a start from which such features could easily be implemented.

fmauch added 17 commits September 15, 2020 07:34
@fmauch
source and message types should be signed
489bda3
@fmauch
Added constructor with package type for RobotMessage
e525114
@fmauch
Initialize message_type in VersionMessage
19892ba
@fmauch
Added virtual destructor for URProducer
236cc61
@fmauch
Added TextMessage and KeyMessage
986ffc8
@fmauch
Added error_code and runtime_exception message
a76c52a 
Note: The error_code message changed between versions 5.1 and 5.2
@fmauch
fixup! Added TextMessage and KeyMessage
4a589d4
@fmauch
Added consumer functions to new message types
4ee077e
@fmauch
Added a draft version for a primary client
cd984ba
@fmauch
WIP: Move primary interface logic to primary client
53e052b
@fmauch
Print title over key message
ac149ff
@fmauch
Added handler for ErrorCode messages
9ffd1fe
@fmauch
fixup! Added TextMessage and KeyMessage
0fe9456
@fmauch
fixup! Added error_code and runtime_exception message
c872e02
@fmauch
fixup! Added a draft version for a primary client
9997b84
@fmauch
fixup! WIP: Move primary interface logic to primary client
5a88fc4
@fmauch
Corrected header guard namings
6f87e4b
@fmauch fmauch mentioned this pull request Sep 15, 2020
Closed
@fmauch fmauch marked this pull request as draft September 15, 2020 06:22
@fmauch fmauch force-pushed the improve_primary_interface branch from 1d86da8 to 3da1c2b Compare February 21, 2022 15:31
@urmahp urmahp mentioned this pull request Sep 29, 2023
Open
@fmauch
Copy link
Contributor Author

fmauch commented May 28, 2024

Closing this in favor of #186

@fmauch fmauch closed this May 28, 2024
@urfeex urfeex deleted the improve_primary_interface branch December 18, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fmauch