Reduce local cache time and purge on update (#1286)

Universalis-FFXIV · Jul 18, 2024 · 215ef27 · 215ef27
1 parent c85190e
commit 215ef27
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Universalis.DbAccess/MarketBoard/ListingStore.cs b/src/Universalis.DbAccess/MarketBoard/ListingStore.cs
@@ -48,6 +48,7 @@ private static readonly Counter
         Prometheus.Metrics.CreateCounter("universalis_listing_local_cache_update", "");
 
     private static readonly TimeSpan ListingsCacheTime = TimeSpan.FromMinutes(10);
+    private static readonly TimeSpan LocalListingsCacheTime = TimeSpan.FromSeconds(30);
 
     private readonly ILogger<ListingStore> _logger;
     private readonly ICacheRedisMultiplexer _cache;
@@ -85,6 +86,7 @@ public async Task DeleteLive(ListingQuery query, CancellationToken cancellationT
         var db = _cache.GetDatabase(RedisDatabases.Cache.Listings);
         var cacheKey = ListingsKey(query.WorldId, query.ItemId);
         await db.KeyDeleteAsync(cacheKey);
+        await _easyCachingProvider.RemoveAsync(cacheKey, cancellationToken);
         CachePurges.Inc();
     }
 
@@ -168,6 +170,7 @@ INSERT INTO listing
                 var db = _cache.GetDatabase(RedisDatabases.Cache.Listings);
                 var cacheKey = ListingsKey(worldID, itemID);
                 await db.KeyDeleteAsync(cacheKey);
+                await _easyCachingProvider.RemoveAsync(cacheKey, cancellationToken);
                 CachePurges.Inc();
             }
             catch (Exception e)
@@ -425,7 +428,7 @@ await db.StringSetAsync(cacheKey, SerializeListings(listings), ListingsCacheTime
         if (cacheValue.HasValue)
         {
             LocalCacheHits.Inc();
-            return (true, cacheValue.Value);
+            return (true, cacheValue.Value.OrderBy(listing => listing.PricePerUnit).ToList());
         }
         else
         {
@@ -439,7 +442,7 @@ private async Task StoreListingsInLocalCache(int worldId, int itemId, IList<List
     {
         using var activity = Util.ActivitySource.StartActivity("ListingStore.StoreListingsInLocalCache");
         var cacheKey = ListingsKey(worldId, itemId);
-        await _easyCachingProvider.SetAsync(cacheKey, listings, ListingsCacheTime, cancellationToken);
+        await _easyCachingProvider.SetAsync(cacheKey, listings, LocalListingsCacheTime, cancellationToken);
         LocalCacheUpdates.Inc();
     }