Add metric for user agent requests (#1288)

Universalis-FFXIV · Jul 18, 2024 · b2f1dae · b2f1dae
1 parent 2363944
commit b2f1dae
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/src/Universalis.Application/Controllers/CurrentlyShownControllerBase.cs b/src/Universalis.Application/Controllers/CurrentlyShownControllerBase.cs
@@ -3,6 +3,7 @@
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
+using Prometheus;
 using Universalis.Application.Common;
 using Universalis.Application.Views.V1;
 using Universalis.DataTransformations;
@@ -16,6 +17,9 @@ namespace Universalis.Application.Controllers;
 
 public class CurrentlyShownControllerBase : WorldDcRegionControllerBase
 {
+    protected static readonly Counter UserAgentRequestCount =
+        Metrics.CreateCounter("universalis_request_count_user_agents", "", "Controller", "Family");
+
     protected readonly ICurrentlyShownDbAccess CurrentlyShown;
     protected readonly IHistoryDbAccess History;
 

diff --git a/src/Universalis.Application/Controllers/V1/CurrentlyShownController.cs b/src/Universalis.Application/Controllers/V1/CurrentlyShownController.cs
@@ -74,6 +74,9 @@ public async Task<IActionResult> Get(
             var parsedUserAgent = Parser.GetDefault().ParseUserAgent(userAgent);
             var userAgentFamily = parsedUserAgent.Family;
             activity?.AddTag("userAgent", userAgentFamily);
+
+            // TODO: pull controller name extraction out to a util
+            UserAgentRequestCount.Labels("CurrentlyShown", userAgentFamily).Inc();
         }
 
         if (itemIds == null || worldDcRegion == null)

diff --git a/src/Universalis.Application/Controllers/V2/CurrentlyShownController.cs b/src/Universalis.Application/Controllers/V2/CurrentlyShownController.cs
@@ -75,6 +75,7 @@ public async Task<IActionResult> Get(
             var parsedUserAgent = Parser.GetDefault().ParseUserAgent(userAgent);
             var userAgentFamily = parsedUserAgent.Family;
             activity?.AddTag("userAgent", userAgentFamily);
+            UserAgentRequestCount.Labels("CurrentlyShown", userAgentFamily).Inc();
         }
 
         if (itemIds == null || worldDcRegion == null)