fix FadeIn() and FadeOut() in Mode 5 #146
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to ProcessFading() was commented out. Because of this all calls to FadeIn()/FadeOut() with a speed > 0 resulted in a complete hang.
|
Any comments on this @uze6666 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to ProcessFading() was commented out. Because of this all calls to FadeIn()/FadeOut() with a speed > 0 in Mode 5 resulted in a complete hang.
Looking at the source code, Mode 10 should have the same problem, but as I've only found this bug and verified this fix under Mode 5, I did not include a fix for Mode 10.
I've already posted this on the Uzebox forums – this is by no means a "work faster to fix this" reminder ;-)
I need this fix in a repository so that I can refer to it in the build instructions of Uzepede. After creating my fork of the Uzebox repo and comitting this fix, opening the Pull Request was just a click away, so here we are.