Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintained RpcReqError with headers in kphp #926

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

DrDet
Copy link
Contributor

@DrDet DrDet commented Oct 31, 2023

Changes

  • Refactored RpcReqError fetching to get rid of copy-paste
  • Maintained RpcReqError with headers. When it comes with headers they're just skipped and an error TL object is returned as usual.

relates to #915

@DrDet DrDet added the runtime Feature related to runtime label Oct 31, 2023
@DrDet DrDet added this to the next milestone Oct 31, 2023
@DrDet DrDet self-assigned this Oct 31, 2023
@DrDet DrDet requested a review from troy4eg November 1, 2023 13:09
@DrDet DrDet merged commit 7a89f96 into master Nov 7, 2023
5 checks passed
@DrDet DrDet deleted the dvaksman/maintain-rpc-error-header-fetching-in-kphp branch November 7, 2023 12:08
astrophysik pushed a commit that referenced this pull request Nov 9, 2023
* refactored RpcReqError fetching, get rid of copy-paste

* maintain RpcReqError with header fetching. Header is ignored after fetching
astrophysik added a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime Feature related to runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants