Driver rpc tries #3203
Open
Driver rpc tries #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatible with wheel 0.30.0.
…ace is not ready before RPC calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try blocks are added to avoid breaking the DriverAgent instance for a device if an RPC method is called before the onstart runs for the DriverAgent. This is necessary because the interface is not ready at the time the RPC arrives. Checking for readiness, meanwhile, would add overhead to every read and write, when this can only happen in the first second or two after creating the device. Instead, we avoid the problem by catching the AttributeError and simply logging that this has happened.
Fixes # (issue)
#3202
Type of change
Please delete options that are not relevant.