-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat: loong64 support for reh server #2084
Conversation
I think I need to take the time to split the
It has been merged
We would need to:
They seem to have a 1-month delay so I think it's better to wait. |
I do think |
After splitting, it seems the two patches cannot be applied together, so I think we need two new folders: In (BTW, it's midnight now in my time zone, I might not respond until morning) |
I've split the
So to add/edit your new arch, you will need to run the command |
--- a/build/npm/postinstall.js | ||
+++ b/build/npm/postinstall.js | ||
@@ -56,3 +56,3 @@ function yarnInstall(dir, opts) { | ||
@@ -53,8 +53,10 @@ function npmInstall(dir, opts) { | ||
log(dir, `Installing dependencies inside container ${process.env['VSCODE_REMOTE_DEPENDENCIES_CONTAINER_NAME']}...`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the command ./patch.sh linux/yarn-dependencies.patch
to edit that file. It will remove the extra lines.
bd66bda
to
1731aa5
Compare
This PR introduces loong64 support for REH server. The loong64 is a RISC-style ISA developed by Loongson.
I am still working on porting the client to loong64, and will open another PR soon.
WIP: This PR uses
ghcr.io/darkyzhou/vscodium-linux-build-agent:trixie-devtoolset-loong64
forVSCODE_REMOTE_DEPENDENCIES_CONTAINER_NAME
, which will be updated after VSCodium/vscode-linux-build-agent#23 gets merged.BTW, once this gets merged, can we build reh server on loong64 for older releases? Other VSCode variants like Cursor still uses
1.93.1
.