Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DKMS requiring manual version updates in waydroid module #245

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Maxwelldoug
Copy link

This PR is fairly self explanatory. Honestly, I don't know why this is structured as it is in the first place.

@kbdharun kbdharun requested review from taukakao and kbdharun January 17, 2025 12:23
@Maxwelldoug
Copy link
Author

That build failure is not my fault, the error is

#32 ERROR: process "/bin/sh -c apt-get install -y  cups cups-pk-helper cups-filters bluez-cups printer-driver-brlaser printer-driver-escpr hplip system-config-printer-common system-config-printer-udev  && apt-get clean" did not complete successfully: exit code: 100
------
 > [27/52] RUN apt-get install -y  cups cups-pk-helper cups-filters bluez-cups printer-driver-brlaser printer-driver-escpr hplip system-config-printer-common system-config-printer-udev  && apt-get clean:
0.765 Some packages could not be installed. This may mean that you have
0.765 requested an impossible situation or if you are using the unstable
0.765 distribution that some required packages have not yet been created
0.765 or been moved out of Incoming.
0.765 The following information may help to resolve the situation:
0.765 
0.765 The following packages have unmet dependencies:
0.828  hplip : Depends: python3 (< 3.13) but 3.13.1-2 is to be installed
0.828          Recommends: printer-driver-postscript-hp but it is not going to be installed
0.833 E: Unable to correct problems, you have held broken packages.

which seems to be a repo problem.

@kbdharun
Copy link
Member

kbdharun commented Jan 17, 2025

Yeah, went through the Debian tracker and seems like this is a known issue https://tracker.debian.org/pkg/hplip. Let's try commenting out the package and see how the build goes. That seems to have worked, let me discuss with the team about this and then merge this PR.

@kbdharun kbdharun changed the title fix DKMS requires manual version updates in waydroid module fix: DKMS requiring manual version updates in waydroid module Jan 17, 2025
@taukakao
Copy link
Member

taukakao commented Jan 17, 2025

This needs to rebased onto #246 first. (After that is merged ofc)
Also, maybe it would be a good idea to write the kernel version into a file after installing the kernel and then reading from that file.

That way, if the method of determining the kernel version was wrong, we only have to change it in one spot.

@taukakao taukakao mentioned this pull request Jan 17, 2025
@taukakao
Copy link
Member

I created Vanilla-OS/core-image#99
Let me know what you think

@Maxwelldoug
Copy link
Author

Works for me - I was mainly worried about the logic existing, but your implementation is probably more sensible long term.

modules/02-waydroid-modules.yml Outdated Show resolved Hide resolved
modules/80-printers.yml Outdated Show resolved Hide resolved
@Maxwelldoug
Copy link
Author

Maxwelldoug commented Jan 17, 2025

Both points resolved. This should be good to merge, and will fix the current build failure.

@Maxwelldoug
Copy link
Author

@taukakao You seem to have closed this PR without actually making its main change in the waydroid module. Was this intentional?

@taukakao
Copy link
Member

@Maxwelldoug Yeah, sorry, I accidentally pushed the wrong branch to this PR branch and messed up the history. Github closed the PR automatically.
Could you quickly sync your dev branch with the original dev branch, otherwise I don't have the permission to push.

(I squashed the commits)

@taukakao
Copy link
Member

I will reopen and merge the PR afterwards.

@Maxwelldoug
Copy link
Author

You actually managed to push my repo a half dozen commits behind when I originally forked it without any permissions on it. Kind of Impressive.

@Maxwelldoug
Copy link
Author

It's back now

@Maxwelldoug
Copy link
Author

Bruh

@taukakao
Copy link
Member

Here we go, sorry for the inconvenience @Maxwelldoug

@taukakao taukakao merged commit 42916e5 into Vanilla-OS:dev Jan 17, 2025
@taukakao
Copy link
Member

You actually managed to push my repo a half dozen commits behind when I originally forked it without any permissions on it. Kind of Impressive.

Also this is because when you create a PR maintainers of the original repo automatically get full access to the branch unless you disable that manually in the PR. Doesn't have anything to do with the permissions of the fork itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants