-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DKMS requiring manual version updates in waydroid module #245
Conversation
That build failure is not my fault, the error is
which seems to be a repo problem. |
Yeah, went through the Debian tracker and seems like this is a known issue https://tracker.debian.org/pkg/hplip. |
This needs to rebased onto #246 first. (After that is merged ofc) That way, if the method of determining the kernel version was wrong, we only have to change it in one spot. |
I created Vanilla-OS/core-image#99 |
Works for me - I was mainly worried about the logic existing, but your implementation is probably more sensible long term. |
Both points resolved. This should be good to merge, and will fix the current build failure. |
@taukakao You seem to have closed this PR without actually making its main change in the waydroid module. Was this intentional? |
@Maxwelldoug Yeah, sorry, I accidentally pushed the wrong branch to this PR branch and messed up the history. Github closed the PR automatically. (I squashed the commits) |
I will reopen and merge the PR afterwards. |
You actually managed to push my repo a half dozen commits behind when I originally forked it without any permissions on it. Kind of Impressive. |
It's back now |
Bruh |
Here we go, sorry for the inconvenience @Maxwelldoug |
Also this is because when you create a PR maintainers of the original repo automatically get full access to the branch unless you disable that manually in the PR. Doesn't have anything to do with the permissions of the fork itself. |
This PR is fairly self explanatory. Honestly, I don't know why this is structured as it is in the first place.