Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(JAVA-W0146) Throw exception in next method #10

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

desacu
Copy link
Contributor

@desacu desacu commented Oct 4, 2024

Hi @VerisimilitudeX, as per my understanding what you requested in this issue #3 is what I have done in this PR. Could you check, please? It that's not the case, could you clarify a little bit? I do not have access to the deepsource link. It shows me a 404 error when I try to have a look.

Thank you

Closes #3.

@desacu desacu changed the title Throw exception in next method (JAVA-W0146) Throw exception in next method Oct 4, 2024
Copy link
Owner

@VerisimilitudeX VerisimilitudeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @desacu this looks great! Could you just fix the merge conflicts? Thanks.

I would also really appreciate it if you could star the DNAnalyzer repository (https://github.com/VerisimilitudeX/DNAnalyzer) to show your support, if you haven't done so already. I (or another member from our team) will review your PR in the next 48 hours, and will get back to you. If you have any questions, please join our Discord server: https://discord.gg/X3YCvGf2Ug.

@VerisimilitudeX VerisimilitudeX marked this pull request as draft December 18, 2024 01:57
@VerisimilitudeX
Copy link
Owner

Please re-request a review from me once you do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(JAVA-W0146) Iterator next method should throw NoSuchElementException
2 participants