feat: Add WebID attestation for requests to llm_service (alternative) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version uses Header parameter for retrieving header. But `Optional` does not seem to be respected correctly.
renyuneyun
force-pushed
the
attest-webid_header-param
branch
from
fef455e to
300f379
Compare
renyuneyun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version uses Header parameter for retrieving header. But
Optionaldoes not seem to be respected correctly.This is almost the same as the other branch
attest-webid, but differs in the way how headers are retrieved. This version should be preferred, as it makes use of FastAPI's built-in mechanism to verify parameters. However, it's not fully functioning as expected (see above).Only one of them needs to be used.