VCST-2487: Enhance CSV module with new features and refactorings #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Added PrimaryImageGroup and AtlImageGroupName to setyp Image grop. feat: Improved BOM detection. feat: Removed Ude.NetStandard package. feat: Added UI for column delimiter selection for export. feat: Set default column delimiter to comma.
vc-ci
reviewed
Jan 16, 2025
vc-ci
reviewed
Jan 17, 2025
artem-dudarev
previously approved these changes
Jan 17, 2025
src/VirtoCommerce.CatalogCsvImportModule.Core/Model/CsvProduct.cs
Outdated
Show resolved
Hide resolved
tests/VirtoCommerce.CatalogCsvImportModule.Test/ImporterTests.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.CatalogCsvImportModule.Web/Scripts/resources/import.js
Outdated
Show resolved
Hide resolved
vc-ci
reviewed
Jan 17, 2025
vc-ci
reviewed
Jan 17, 2025
Co-authored-by: Artem Dudarev <ad@virtoway.com>
|
vc-ci
reviewed
Jan 17, 2025
vc-ci
reviewed
Jan 17, 2025
artem-dudarev
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: Added PrimaryImageGroup and AtlImageGroupName to setup Image group.
feat: Improved BOM detection.
feat: Removed Ude.NetStandard package.
feat: Added UI for column delimiter selection for export.
feat: Set default column delimiter to comma.
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-2487
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.CatalogCsvImportModule_3.805.0-pr-111-20c7.zip