Refactoring

VirtoCommerce · Nov 12, 2024 · 6a15605 · 6a15605
1 parent 21f21a9
commit 6a15605
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/src/VirtoCommerce.QuoteModule.ExperienceApi/Commands/AddQuoteItemsCommandHandler.cs b/src/VirtoCommerce.QuoteModule.ExperienceApi/Commands/AddQuoteItemsCommandHandler.cs
@@ -30,16 +30,16 @@ protected override async Task UpdateQuoteAsync(QuoteRequest quote, AddQuoteItems
             StoreId = quote.StoreId,
             CurrencyCode = quote.Currency,
             ObjectIds = productIds,
-            IncludeFields = new string[]
-            {
+            IncludeFields =
+            [
                 "__object",
                 "price",
                 "images",
                 "properties",
                 "description",
                 "slug",
                 "outlines"
-            },
+            ],
             EvaluatePromotions = false,
         };
 
@@ -57,12 +57,13 @@ protected virtual void AddQuoteItems(QuoteRequest quote, AddQuoteItemsCommand re
         {
             var quoteItem = AbstractTypeFactory<QuoteItem>.TryCreateInstance();
 
-            var product = productsByIds.GetValueSafe(newQuoteItem.ProductId);
-            var price = product?.AllPrices.FirstOrDefault();
-
+            quoteItem.ProductId = newQuoteItem.ProductId;
             quoteItem.Name = newQuoteItem.Name;
+            quoteItem.Comment = newQuoteItem.Comment;
+            quoteItem.Quantity = newQuoteItem.Quantity;
+            quoteItem.Currency = quote.Currency;
 
-            quoteItem.ProductId = newQuoteItem.ProductId;
+            var product = productsByIds.GetValueSafe(newQuoteItem.ProductId);
             if (product != null)
             {
                 quoteItem.Name = product.IndexedProduct.Name;
@@ -73,14 +74,10 @@ protected virtual void AddQuoteItems(QuoteRequest quote, AddQuoteItemsCommand re
                 quoteItem.TaxType = product.IndexedProduct.TaxType;
             }
 
+            var price = product?.AllPrices.FirstOrDefault();
             quoteItem.ListPrice = price?.ListPrice.InternalAmount ?? 0;
             quoteItem.SalePrice = price?.SalePrice.InternalAmount ?? 0;
 
-            quoteItem.Comment = newQuoteItem.Comment;
-            quoteItem.Currency = quote.Currency;
-
-            quoteItem.Quantity = newQuoteItem.Quantity;
-
             var tierPrice = AbstractTypeFactory<TierPrice>.TryCreateInstance();
             tierPrice.Price = newQuoteItem.Price ?? quoteItem.SalePrice;
             tierPrice.Quantity = newQuoteItem.Quantity;