fix sonar warning

VirtoCommerce · Jun 11, 2024 · c24c019 · c24c019
1 parent 0b89f77
commit c24c019
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/VirtoCommerce.QuoteModule.Web/Scripts/blades/quote-detail.js b/src/VirtoCommerce.QuoteModule.Web/Scripts/blades/quote-detail.js
@@ -3,6 +3,9 @@ angular.module('virtoCommerce.quoteModule')
         'platformWebApp.bladeNavigationService', 'platformWebApp.settings', 'platformWebApp.dialogService', 'platformWebApp.metaFormsService',
         'virtoCommerce.quoteModule.quotes', 'virtoCommerce.customerModule.members',
             function ($scope, bladeNavigationService, settings, dialogService, metaFormsService, quotes, members) {
+
+                const QuoteProposalSentStatus = 'Proposal sent';
+
                 var blade = $scope.blade;
 
                 var onHoldCommand = {
@@ -156,7 +159,7 @@ angular.module('virtoCommerce.quoteModule')
                                     message: "quotes.dialogs.proposal-submit-with-warning.message",
                                     callback: function (ok) {
                                         if (ok) {
-                                            blade.currentEntity.status = 'Proposal sent';
+                                            blade.currentEntity.status = QuoteProposalSentStatus;
                                             saveChanges();
                                         }
                                     }
@@ -170,7 +173,7 @@ angular.module('virtoCommerce.quoteModule')
                                     message: "quotes.dialogs.proposal-submit.message",
                                     callback: function (ok) {
                                         if (ok) {
-                                            blade.currentEntity.status = 'Proposal sent';
+                                            blade.currentEntity.status = QuoteProposalSentStatus;
                                             saveChanges();
                                         }
                                     }
@@ -179,7 +182,7 @@ angular.module('virtoCommerce.quoteModule')
                             }
                         },
                         canExecuteMethod: function () {
-                            return blade.origEntity && blade.origEntity.status !== 'Proposal sent';
+                            return blade.origEntity && blade.origEntity.status !== QuoteProposalSentStatus;
                         },
                         permission: blade.updatePermission
                     },