Skip to content
Module CI

VCST-335: get cards list from skyflow #55

Sign in to view logs

VCST-335: get cards list from skyflow

VCST-335: get cards list from skyflow #55

Triggered via pull request March 6, 2024 12:34
@basilkotbasilkot
synchronize #5
feat/VCST-335-cards-list
Status Success
Total duration 2m 16s
Artifacts –

module-ci.yml

on: pull_request
ci
1m 53s
ci
module-katalon-tests  /  e2e-tests
module-katalon-tests / e2e-tests
Matrix: deploy-cloud / Deploy
Waiting for pending jobs
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/Services/SkyflowClient.cs(58,13): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/VirtoCommerce.Skyflow.Data.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/Services/SkyflowClient.cs(168,9): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/VirtoCommerce.Skyflow.Data.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/Providers/SkyflowPaymentMethod.cs(17,33): warning S4462: Replace this use of 'Task.Result' with 'await'. (https://rules.sonarsource.com/csharp/RSPEC-4462) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/VirtoCommerce.Skyflow.Data.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/Providers/SkyflowPaymentMethod.cs(48,41): warning S4462: Replace this use of 'Task.GetAwaiter.GetResult' with 'await'. (https://rules.sonarsource.com/csharp/RSPEC-4462) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/VirtoCommerce.Skyflow.Data.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/Services/DefaultPaymentClient.cs(72,32): warning S4462: Replace this use of 'Task.GetAwaiter.GetResult' with 'await'. (https://rules.sonarsource.com/csharp/RSPEC-4462) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/VirtoCommerce.Skyflow.Data.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/Services/SkyflowClient.cs(48,17): warning S1117: Rename 'options' which hides the primary constructor parameter with the same name. (https://rules.sonarsource.com/csharp/RSPEC-1117) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/VirtoCommerce.Skyflow.Data.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.XApi/Queries/SkyflowCardQueryHandler.cs(21,19): warning S3928: The parameter name 'StoreId' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.XApi/VirtoCommerce.Skyflow.XApi.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.XApi/Queries/SkyflowCardQueryHandler.cs(17,44): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.XApi/VirtoCommerce.Skyflow.XApi.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/Services/SkyflowClient.cs(58,13): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/VirtoCommerce.Skyflow.Data.csproj]
ci
/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/Services/SkyflowClient.cs(168,9): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-module-skyflow/vc-module-skyflow/src/VirtoCommerce.Skyflow.Data/VirtoCommerce.Skyflow.Data.csproj]