Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCST-1867: Mark IsSpa, SubscriptionEnabled and QuotesEnabled as Deprecated #13

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

OlegoO
Copy link
Contributor

@OlegoO OlegoO commented Sep 30, 2024

Description

fix: Mark IsSpa, SubscriptionEnabled and QuotesEnabled as deprecated properties. Use Quotes.EnableQuotes public property instead. Client application should use own business logic for SPA detection. Both properties will be removed after 11 stable release.

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-1867

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Xapi_3.810.0-pr-13-bf6c.zip

fix: Mark IsSpa, SubscriptionEnabled and QuotesEnabled as deprecated properties. Use Quotes.EnableQuotes public property instead. Client application should use own business logic for SPA detection. Both properties will be removed after 11 stable release.
@OlegoO OlegoO requested a review from ksavosteev September 30, 2024 14:44
@OlegoO OlegoO changed the title VCST-1867: Mark IsSpa and QuotesEnabled as Deprecated VCST-1867: Mark IsSpa, SubscriptionEnabled and QuotesEnabled as Deprecated Sep 30, 2024
Copy link

sonarqubecloud bot commented Oct 4, 2024

@OlegoO OlegoO merged commit 0c7b7e7 into dev Oct 4, 2024
5 checks passed
@OlegoO OlegoO deleted the fix/VCST-1867 branch October 4, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant