add a workaround for nulls in non-nullable fields

Signed-off-by: Julia Plewa <jplewa@virtuslab.com>
VirtuslabRnD · Apr 23, 2024 · 2793075 · 2793075
1 parent c6735b8
commit 2793075
Showing 1 changed file with 24 additions and 5 deletions.
diff --git a/src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step3codegen/types/TypeGenerator.kt b/src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step3codegen/types/TypeGenerator.kt
@@ -46,6 +46,11 @@ import kotlin.streams.asSequence
 
 object TypeGenerator {
 
+    private val nullabilityExceptions = listOf(
+        NullabilityException("com.pulumi.gcp.organizations.kotlin.outputs", "GetProjectResult", "autoCreateNetwork"),
+        NullabilityException("com.pulumi.gcp.organizations.kotlin.outputs", "GetProjectResult", "skipDelete"),
+    )
+
     fun generateTypes(
         types: List<RootType>,
         generationOptions: GenerationOptions = GenerationOptions(),
@@ -56,7 +61,7 @@ object TypeGenerator {
             val isFunction = usageKind.subject == Function
             val isOutput = usageKind.direction == Output
             val fields = if (isFunction || isOutput) {
-                prepareFieldsForTypesUsedForFunctionsOrAsOutput(type)
+                prepareFieldsForTypesUsedForFunctionsOrAsOutput(typeNameClashResolver, type)
             } else {
                 prepareFields(type)
             }
@@ -82,16 +87,24 @@ object TypeGenerator {
             )
         }
 
-    private fun prepareFieldsForTypesUsedForFunctionsOrAsOutput(type: ComplexType) =
-        type.fields.map { (name, typeAndOptionality) ->
+    private fun prepareFieldsForTypesUsedForFunctionsOrAsOutput(
+        typeNameClashResolver: TypeNameClashResolver,
+        type: ComplexType,
+    ): List<Field<ReferencedType>> {
+        val className = typeNameClashResolver.kotlinNames(type.metadata)
+        return type.fields.map { (fieldName, typeAndOptionality) ->
+            val isNullabilityException = nullabilityExceptions.contains(
+                NullabilityException(className.packageName, className.className, fieldName),
+            )
             Field(
-                name,
+                fieldName,
                 NormalField(typeAndOptionality.type) { it },
-                typeAndOptionality.type !is OptionalType,
+                !(typeAndOptionality.type is OptionalType || isNullabilityException),
                 overloads = emptyList(),
                 typeAndOptionality.kDoc,
             )
         }
+    }
 
     private fun generateFile(context: Context, typeNameClashResolver: TypeNameClashResolver): FileSpec {
         val typeMetadata = context.typeMetadata
@@ -307,4 +320,10 @@ object TypeGenerator {
         val fields: List<Field<ReferencedType>>,
         val options: GenerationOptions,
     )
+
+    private data class NullabilityException(
+        val packageName: String,
+        val typeName: String,
+        val fieldName: String,
+    )
 }