update decapitalization mechanism

Signed-off-by: Julia Plewa <jplewa@virtuslab.com>
VirtuslabRnD · Jul 19, 2023 · b302703 · b302703
1 parent 1f235bf
commit b302703
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiName.kt b/src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiName.kt
@@ -205,8 +205,10 @@ data class PulumiName(
 
     fun toResourceFunctionName(namingFlags: NamingFlags): String {
         val resourceName = toResourceName(namingFlags)
-        val numberOfCaps = resourceName.takeWhile { it.isUpperCase() }.count()
-        return if (numberOfCaps > 1) {
+        val numberOfCaps = resourceName.takeWhile { it.isUpperCase() || it.isDigit() }.count()
+        return if (numberOfCaps == resourceName.length) {
+            resourceName.lowercase()
+        } else if (numberOfCaps > 1) {
             resourceName.lowercaseBefore(numberOfCaps - 1)
         } else {
             resourceName.decapitalize()

diff --git a/src/test/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiNameTest.kt b/src/test/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiNameTest.kt
@@ -586,6 +586,21 @@ internal class PulumiNameTest {
         assertEquals("iamBinding", resourceFunctionName)
     }
 
+    @Test
+    fun `a resource function name that is a three-letter acronym is decapitalized correctly`() {
+        // given
+        val token = "provider:module:CRL"
+        val namingConfiguration = PulumiNamingConfiguration.create(providerName = "provider")
+
+        // when
+        val pulumiName = PulumiName.from(token, namingConfiguration)
+        val namingFlags = NamingFlags(Root, Resource, Input, Java)
+        val resourceFunctionName = pulumiName.toResourceFunctionName(namingFlags)
+
+        // then
+        assertEquals("crl", resourceFunctionName)
+    }
+
     @Test
     fun `a resource function name starting with a two-letter acronym and number is decapitalized correctly`() {
         // given
@@ -598,6 +613,6 @@ internal class PulumiNameTest {
         val resourceFunctionName = pulumiName.toResourceFunctionName(namingFlags)
 
         // then
-        assertEquals("eC2Fleet", resourceFunctionName)
+        assertEquals("ec2Fleet", resourceFunctionName)
     }
 }