Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sound assets #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add sound assets #8

wants to merge 1 commit into from

Conversation

arthurkehrwald
Copy link

This was referenced Jan 8, 2025
Open
Open
Open
@freezy
Copy link
Member

freezy commented Jan 13, 2025

Hey,

Could you grab the unity-2022 branch of this repo and apply your patch from VisualPinball/VisualPinball.Unity.Hdrp#22 to the prefabs here? Thing is I've also moved the prefabs, but not to HDRP, but to this repo.

As far as I can see, it touches only bumper and gate.

@freezy
Copy link
Member

freezy commented Jan 13, 2025 •
edited
Loading

Actually, take the feature/sounds-rebased branch, which contains your branch here on top of mine. You can test it with the feature/sounds-rebased branch in the main repo.

I'm now rebasing your HDRP branch by re-instating the missing files and applying code changes only, it'll also be called feature/sounds-rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurkehrwald @freezy