Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miri dependency issue #48

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Fix miri dependency issue #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a16aa4e
Fix new warnings in tests
Voultapher Oct 29, 2023
6dd83b0
Fix miri dependency issue
Voultapher Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions tests-extra/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tests-extra/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ trybuild = "=1.0.37"
# Pin specific versions to ensure transitive dependencies.
serde_json = "=1.0.6"
serde = "=1.0.103"
proc-macro2 = "=1.0.43"
4 changes: 1 addition & 3 deletions tests/self_cell.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// The unsafe being used gets tested with miri in the CI.

#![deny(private_in_public)]

use std::cell::Cell;
use std::cell::RefCell;
use std::fmt::Debug;
Expand Down Expand Up @@ -185,7 +183,7 @@ fn from_fn() {

let expected_str = "small pink bike";

let fn_cell = FnCell::new(expected_str.clone().into(), |owner| {
let fn_cell = FnCell::new(expected_str.into(), |owner| {
// Make sure it only gets called once.
extra_outside_state = if let Some(x) = extra_outside_state {
Some(x + 5)
Expand Down