Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment7 juhee hwang #7

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Juhee-Hwang
Copy link
Contributor

@Juhee-Hwang Juhee-Hwang commented Dec 17, 2021

📌 내용

기본과제

  • 세미나에서 다룬 내용 구현
  • 이미지 미리보기 구현
2021-12-18.12.34.58.mov

Copy link
Member

@SeojinSeojin SeojinSeojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막까지 넘넘넘넘넘 수고 많았따~!!!!~!!!!


return (
<StyledRoot>
<StyledLeft onClick={() => navigate("/")}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link 컴포넌트를 써도 좋을 것 같습니다!!

const HomeNav = () => {
const [isArticleBottomLine, setIsArticleBottomLine] = useState(true);

const handleClick = (e) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이벤트 헨들러 하나 속에서 다 처리하는 거라면,
기냥 StyledRoot의 온클릭 리스너로 얘를 달아주고 이벤트 위임을 시켜도 괜찮을 듯합니다!!

<a href="https://github.com/Juhee-Hwang" target="blank">
<GithubIcon fill="lightGray" />
</a>
<a href="https://2runzzal.com/uploads/zpicture/org/d2cf5c4811c675ae485fe3e03aa2b6adbbd3740ffdd59bec0f7d26e7409c08a4.jpg" target="blank">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋㅋ 짤 머야!!

@@ -0,0 +1,11 @@
export const colors = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상수 넘 조아~~

`;

const StyledCenterLine = styled.div`
background-color: rgb(233, 236, 239);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 친구도 상수로 처리하면 좋을듯합니다..!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants