Added a very interesting TODO in the rabbit "hole"

WebReflection · Jan 5, 2024 · 53a663c · 53a663c
1 parent bc0a0ee
commit 53a663c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/esm/literals.js b/esm/literals.js
@@ -74,7 +74,7 @@ export const entry = (t, p, u, n = '') => ({ t, p, u, n });
  * @param {Cache[]} s the cache stack
  * @returns {Cache}
  */
-export const cache = s => ({ s, t: null, n: null, d: empty});
+export const cache = s => ({ s, a: false, t: null, n: null, d: empty});
 
 /**
  * @typedef {Object} Parsed

diff --git a/esm/rabbit.js b/esm/rabbit.js
@@ -35,6 +35,12 @@ export const unroll = (cache, { s: svg, t: template, v: values }) => {
   return cache.n;
 };
 
+// TODO: check twice for isArray or check attributes
+//       makes literally no sense and it's performance
+//       critical. The template details know all of this
+//       so there's gonna be a way to drill those details
+//       down this loop, avoiding any unnecessary check.
+
 /**
  * @param {Cache} cache
  * @param {any[]} values

diff --git a/signal.js b/signal.js