Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved bug where course_update would delete the remui image when not … #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solved bug where course_update would delete the remui image when not … #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 26 additions & 17 deletions lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,30 +633,39 @@ public function get_config_for_external() {
* If $data does not contain property with the option name, the option will not be updated
*
* @param stdClass|array $data return value from moodleform::get_data() or array with data
* @param int $sectionid Section id
* @param stdClass|array $oldcourse Old course id
* @return bool whether there were any changes to the options values
*/
public function update_course_format_options($data, $sectionid = null) {
if (!isset($data->remuicourseimage_filemanager)) {
$data->remuicourseimage_filemanager = '';
public function update_course_format_options($data, $oldcourse = null) {
$data = (array) $data;
if ($oldcourse !== null) {
$oldcourse = (array)$oldcourse;
$options = $this->course_format_options();
foreach ($options as $key => $unused) {
if (!array_key_exists($key, $data)) {
if (array_key_exists($key, $oldcourse)) {
$data[$key] = $oldcourse[$key];
}
}
}
}
if (!empty($data)) {

// Used optional_param() instead of using $_POST and $_GET.
$contextid = context_course::instance($this->courseid);
if (!empty($data->remuicourseimage_filemanager)) {
file_postupdate_standard_filemanager(
$data,
'remuicourseimage',
array ('accepted_types' => 'images', 'maxfiles' => 1),
$contextid,
if (isset($data['id']) && $data['id']) {
$courseid = $data['id'];
if (!isset($data["remuicourseimage_filemanager"])) {
$data["remuicourseimage_filemanager"] = '';
}
$contextid = context_course::instance($courseid);
if (!empty($data["remuicourseimage_filemanager"]) && !empty($data["saveanddisplay"])) {
file_save_draft_area_files(
$data['remuicourseimage_filemanager'],
$contextid->id,
'format_remuiformat',
'remuicourseimage_filearea',
$data->remuicourseimage_filemanager
$data["remuicourseimage_filemanager"],
['accepted_types' => 'images', 'maxfiles' => 1]
);
$this->set_remuicourseimage_filemanager($data["remuicourseimage_filemanager"]);
}

$this->set_remuicourseimage_filemanager($data->remuicourseimage_filemanager);
}
return $this->update_format_options($data);
}
Expand Down