Merge pull request #836 from WordPress/830-exclude-in-ruleset-not-wor…

…king-for-json_encode

Update exclude rule for WP alternative functions sniff

phpcs-rulesets/plugin-review.xml

@@ -105,7 +105,7 @@
 	<!-- Check for code WP does better -->
 	<rule ref="WordPress.WP.AlternativeFunctions">
 		<type>error</type>
-		<exclude name="WordPress.WP.AlternativeFunctions.json_encode"/>
+		<exclude name="WordPress.WP.AlternativeFunctions.json_encode_json_encode"/>
 	</rule>
 
 	<rule ref="Generic.PHP.ForbiddenFunctions">

tests/phpunit/testdata/plugins/test-plugin-review-phpcs-errors/load.php

@@ -33,3 +33,5 @@
 
 parse_str( 'first=value&arr[]=foo+bar&arr[]=baz' );
 
+$encoded_value = json_encode( array( 'key' => 'value' ) );
+

tests/phpunit/tests/Checker/Checks/Plugin_Review_PHPCS_Check_Tests.php

@@ -44,6 +44,9 @@ public function test_run_with_errors() {
 		// Check for PluginCheck.CodeAnalysis.RequiredFunctionParameters.parse_str_resultMissing error on Line no 34 and column no at 1.
 		$this->assertSame( 'PluginCheck.CodeAnalysis.RequiredFunctionParameters.parse_str_resultMissing', $errors['load.php'][34][1][0]['code'] );
 
+		// There should not be WordPress.WP.AlternativeFunctions.json_encode_json_encode error on Line no 36 and column no at 18.
+		$this->assertCount( 0, wp_list_filter( $errors['load.php'][36][18], array( 'code' => 'WordPress.WP.AlternativeFunctions.json_encode_json_encode' ) ) );
+
 		// Check for WordPress.Security.ValidatedSanitizedInput warnings on Line no 15 and column no at 27.
 		$this->assertCount( 1, wp_list_filter( $warnings['load.php'][15][27], array( 'code' => 'WordPress.Security.ValidatedSanitizedInput.InputNotValidated' ) ) );
 		$this->assertCount( 1, wp_list_filter( $warnings['load.php'][15][27], array( 'code' => 'WordPress.Security.ValidatedSanitizedInput.MissingUnslash' ) ) );