Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build dev dependency #293

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Update build dev dependency #293

merged 3 commits into from
Oct 18, 2023

Conversation

mukeshpanchal27
Copy link
Member

In PR #166, we established separate development dependencies for lint, phpmd, and phpstan. Therefore, we should ensure that these dependencies are updated alongside the main composer dependencies. This PR updates the WPCS dependency to the latest version.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 16, 2023 07:10
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really just enable Dependabot in this repo

@joemcgill
Copy link
Member

joemcgill commented Oct 17, 2023

@swissspidy it looks like we already have Dependabot running here, see this list of PRs. Do you have something more specific in mind?

[UPDATE] Looks like we only have it set up for security updates, not regular dependency updates. We have #108 already in the backlog for this.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me in the meantime.

@mukeshpanchal27
Copy link
Member Author

Thank you, @joemcgill and @swissspidy. Let's continue the discussion on the tracking issue. I will proceed to merge this PR.

@mukeshpanchal27 mukeshpanchal27 merged commit 6b28da3 into trunk Oct 18, 2023
11 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the update/build-dev-deps branch October 18, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants