Refactoring and Code Duplication Reduction for Plugin_Readme_Check and Trademarks_Check
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Oct 18, 2023
felixarntz
reviewed
Oct 18, 2023
There was a problem hiding this comment.
@mukeshpanchal27 Thank you for the PR. It looks great, my only feedback relates to @swissspidy's existing feedback, I think we can reduce a bit of duplicate code.
swissspidy
approved these changes
Oct 19, 2023
felixarntz
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
@mukeshpanchal27 Thank you for the updates, LGTM!
A few minor nit-picks below, if you can take a look, but not strictly blockers.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286
This pull request introduces two trait classes, which enable us to eliminate code duplications and reuse them throughout the codebase:
Amend_Check_ResultFind_ReadmeChecklist: