Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferred error type to be singular #818

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Preferred error type to be singular #818

merged 1 commit into from
Dec 5, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Dec 5, 2024

Followup #696

Renamed error type to ERROR_LOW_SEVERITY and WARNING_LOW_SEVERITY.

@ernilambar ernilambar added [Type] Bug An existing feature is broken Infrastructure Issues for the overall plugin infrastructure labels Dec 5, 2024
@ernilambar ernilambar changed the title Preferred error type should be singular Preferred error type to be singular Dec 5, 2024
@ernilambar ernilambar added this to the 1.4.0 milestone Dec 5, 2024
@ernilambar ernilambar marked this pull request as ready for review December 5, 2024 04:30
Copy link

github-actions bot commented Dec 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: dd32 <dd32@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@dd32 dd32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with ERROR and WARNING, this makes sense to me.

Ref: #696 (comment)

(Note: the WordPress.org plugin-check implementation will handle this change fine)

@ernilambar ernilambar merged commit f7c814a into trunk Dec 5, 2024
30 checks passed
@ernilambar ernilambar deleted the 696-folloup branch December 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall plugin infrastructure [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants