Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check valid WP version for Requires at least plugin header #852

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 9, 2025

Fixes #851

  • Check added for Requires at least plugin header for validity of WordPress version
  • Version check logic is similar to Tested up to.
  • At 6.7 WP version, error will be generated for more than or equal to WP 6.9
  • Unit tests added for the updated check

@ernilambar ernilambar marked this pull request as ready for review January 9, 2025 08:37
Copy link

github-actions bot commented Jan 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar requested a review from swissspidy January 9, 2025 08:39
@ernilambar ernilambar requested a review from swissspidy January 9, 2025 12:56
@davidperezgar davidperezgar merged commit 4692884 into trunk Jan 9, 2025
28 checks passed
@davidperezgar davidperezgar deleted the 851-check-requires-at-least branch January 9, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Requires at least is a correct value
3 participants