Make links in description body clickable #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am testing with 3 items:
Only works the first item.
I don't know if it works correctly or not. |
|
Nice catch, thank you! |
akirk
requested changes
Feb 19, 2024
templates/event.php
Outdated
| <?php echo esc_html( $event_description ); ?> | ||
| <?php | ||
| // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | ||
| echo make_clickable( wp_kses_post( $event_description ) ); |
There was a problem hiding this comment.
Why not this which would not require the override?
Suggested change
| echo make_clickable( wp_kses_post( $event_description ) ); | |
| echo wp_kses_post( make_clickable( $event_description ) ); |
wporg-gp-translation-events.php
Outdated
| $title = isset( $_POST['event_title'] ) ? sanitize_text_field( wp_unslash( $_POST['event_title'] ) ) : ''; | ||
| $description = isset( $_POST['event_description'] ) ? sanitize_text_field( wp_unslash( $_POST['event_description'] ) ) : ''; | ||
| $title = isset( $_POST['event_title'] ) ? sanitize_text_field( wp_unslash( $_POST['event_title'] ) ) : ''; | ||
| //@codingStandardsIgnoreStart |
There was a problem hiding this comment.
Is it an option to call make_clickable() already here? And why this style of disabling coding standards vs a phpcs:ignore style comment?
There was a problem hiding this comment.
After some tests, we could decide to call make_clickable() here or in the frontend it gives the same result. Do you suggest we rather call it here?
akirk
reviewed
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76