Modify how date is displayed on the event list #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trymebytes
force-pushed
the
modify-list
branch
from
d9d4ae5 to
21e53ca
Compare
akirk
reviewed
Feb 21, 2024
includes/route.php
Outdated
| * | ||
| * @return string The end date text. | ||
| */ | ||
| public static function get_end_date_text( string $event_end ): string { |
There was a problem hiding this comment.
What about putting this in the Event class? Seems like a better fit?
akirk
requested changes
Feb 22, 2024
includes/event.php
Outdated
| $hours_in_a_day = 24; | ||
|
|
||
| if ( $hours_left <= $hours_in_a_day ) { | ||
| return 'ends in ' . $hours_left . ' hours'; |
There was a problem hiding this comment.
Please use translation functions here, specifically _n() it will give us the hour/hours handling for free.
includes/event.php
Outdated
| if ( $hours_left <= $hours_in_a_day ) { | ||
| return 'ends in ' . $hours_left . ' hours'; | ||
| } else { | ||
| return 'until ' . $end_date_time->format( 'M j, Y' ); |
There was a problem hiding this comment.
Let's avoid the string concat and use a sprintf() with a __() and a placeholder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
Before
After
