Prevent the usage of event titles that can conflict with event URLs #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrpinto
approved these changes
Feb 20, 2024
| $title = isset( $_POST['event_title'] ) ? sanitize_text_field( wp_unslash( $_POST['event_title'] ) ) : ''; | ||
| $description = isset( $_POST['event_description'] ) ? sanitize_text_field( wp_unslash( $_POST['event_description'] ) ) : ''; | ||
| $event_start = isset( $_POST['event_start'] ) ? sanitize_text_field( wp_unslash( $_POST['event_start'] ) ) : ''; | ||
| $event_end = isset( $_POST['event_end'] ) ? sanitize_text_field( wp_unslash( $_POST['event_end'] ) ) : ''; | ||
| $event_timezone = isset( $_POST['event_timezone'] ) ? sanitize_text_field( wp_unslash( $_POST['event_timezone'] ) ) : ''; | ||
| if ( isset( $title ) && in_array( sanitize_title( $title ), $invalid_slugs, true ) ) { |
There was a problem hiding this comment.
It has been sanitized above, there's no need to sanitize, right? Though maybe above it should be changed to sanitize_title() instead of sanitize_text_field()?
There was a problem hiding this comment.
What I want in this line is the slug, to look for it in the array, so I think is the correct function, because the title has been sanitized before.
- sanitize_text_field. Sanitizes a string from user input or from the database.
- sanitize_title. Sanitizes a string into a slug.
There was a problem hiding this comment.
Ah, I understand now, thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we can create events with some problematic URLs, used in the routes:
This PR adds a check to avoid the creation of events with these titles:
Fixes #89.