Continuous integration #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
psrpinto
force-pushed
the
tooling
branch
2 times, most recently
from
ffb0e16 to
3af849f
Compare
We'll enable checks as we fix code.
akirk
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run phpcs and phpunit on PRs.
Note that I haven't fixed the coding standards yet. For now
phpcspasses but it doesn't actually check anything.Since there are a lot of things to fix, and they're not just formatting issues (for example, there are input sanitization issues), I would rather fix them iteratively after this PR. For now, I commented out the included files and will enable them as I fix them, in coming PR(s).
TODO