Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'My Events' page #68

Merged
merged 15 commits into from
Feb 15, 2024
Merged

Add 'My Events' page #68

merged 15 commits into from
Feb 15, 2024

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented Feb 13, 2024

Fixes #57

Mockup
image

Updated screenshot
image

@trymebytes trymebytes marked this pull request as draft February 13, 2024 14:43
@trymebytes trymebytes self-assigned this Feb 13, 2024
@trymebytes trymebytes marked this pull request as ready for review February 14, 2024 13:12
@akirk
Copy link
Member

akirk commented Feb 14, 2024

This feels a little visually overloaded for me with two boxes, one of them square and the other round. Could we try something as simple as this?

Screenshot 2024-02-14 at 15 07 08

@trymebytes trymebytes force-pushed the my-events branch 2 times, most recently from a2b433c to b4fd35c Compare February 14, 2024 16:52
@amieiro
Copy link
Collaborator

amieiro commented Feb 15, 2024

You need to remove the link in the title if the event is in draft status.

image

@akirk
Copy link
Member

akirk commented Feb 15, 2024

I think the link should be there so that you can view the event page before publishing it, see #75.

@amieiro
Copy link
Collaborator

amieiro commented Feb 15, 2024

If we want to maintain the link to be able to see the event before publishing it, I will suggest a small tag only for the events in draft status.

image

This is the same approach we are using with the inactive projects in GlotPress:

image

@akirk
Copy link
Member

akirk commented Feb 15, 2024

That would work for me, feel free to experiment.

@trymebytes
Copy link
Collaborator Author

I have added the flag back and it now looks like this;

image

@amieiro
Copy link
Collaborator

amieiro commented Feb 15, 2024

I have changed the 'posts_per_page' => 10, to 'posts_per_page' => 2, here to have pagination, and it doesn't work. You have some pagination code in the events' main page.

image

@trymebytes
Copy link
Collaborator Author

I have fixed this, please pull and try again.

Copy link
Collaborator

@amieiro amieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine for me.

@amieiro amieiro merged commit 66e1094 into trunk Feb 15, 2024
2 checks passed
@amieiro amieiro deleted the my-events branch February 15, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Events page
3 participants